Contributor Guidelines
Our Expectations
We hope that contributing to this project will be a rewarding experience for all our contributors. Notice something that can be improved? Feel free to take a stab at it!
General testing practices and expectations:
- Think about edge cases and failure scenarios.
- Make sure you write unit tests for your work.
- Run all of the unit tests (server, worker, client, and end-to-end) to verify everything is working before submitting a pull request.
- Manually test your work to make sure things look good in the browser (i.e. localhost).
Getting Started
- Fork the repository on GitHub
- Clone the project
- Follow README on GitHub to set up local machine
- Begin Contributing!
Submitting Contributions
- If everything looks good, first update your fork to make sure it’s up to date with the
master
branch of the main repo.- Ensure your commit messages follow Conventional Commit Format
- Please use
rebase
instead ofmerge
to keep your commits on top of the work that has already been committed:git fetch upstream
(make sure you have already set the upstream to PDM GitHub Repo)git rebase upstream/master
- When you have a local commit, push it to your fork.
- Submit your pull request to the core repo. How to Create a Pull Request from a Fork
- A core team dev will then review the pull request. The code review itself will be done via GitHub pull request comments. They will let you know what, if anything, needs to be changed before final submission.
- Once your code has gone through the code review, the pull request will be approved and your code will be merged into master. At this point, you’re done and ready to contribute some more!
Creating a Pull Request
- Raise the pull request to master on the main repository
- if changes includes a changes within
instance-files
, it should be indicated in the pull request description. - Make sure to fill out all the fields in the pull request template.
- if changes includes a changes within
- Your changes should include unit tests that cover the changed functionality.
Suggesting a Feature/Enhancement
- Raise an issue in the Complaint Manager project using the feature request template.
- Make sure to fill out the fields in the template ( the more information we have, the better ).
- Add
needs-review
andfeature
labels to the issue.
Reporting a Bug
- Raise an issue in the Complaint Manager project using the bug template.
- Make sure to fill out the fields in the template ( the more information we have, the better ).
- Add
needs-review
andbug
labels to the issue.
Joining the Community
- PDM Google Group
- Provide Helpful Feedback